From 621a5160025f567e60aec8423e60e41a541d97ce Mon Sep 17 00:00:00 2001
From: isra el <vernu1997@gmail.com>
Date: Sat, 8 Mar 2025 17:35:25 +0300
Subject: [PATCH 1/3] feat(web): auto select device if theres only 1 registered
 device in send sms section

---
 web/app/(app)/dashboard/(components)/send-sms.tsx | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/web/app/(app)/dashboard/(components)/send-sms.tsx b/web/app/(app)/dashboard/(components)/send-sms.tsx
index 01d83ac..9067171 100644
--- a/web/app/(app)/dashboard/(components)/send-sms.tsx
+++ b/web/app/(app)/dashboard/(components)/send-sms.tsx
@@ -89,7 +89,15 @@ export default function SendSms() {
                   name='deviceId'
                   control={control}
                   render={({ field }) => (
-                    <Select onValueChange={field.onChange} value={field.value}>
+                    <Select
+                      onValueChange={field.onChange}
+                      value={field.value}
+                      defaultValue={
+                        devices?.data?.length === 1
+                          ? devices?.data?.[0]?._id
+                          : ''
+                      }
+                    >
                       <SelectTrigger>
                         <SelectValue placeholder='Select a device' />
                       </SelectTrigger>

From 2f0566c407006d044e3a62a9494596abc576f7aa Mon Sep 17 00:00:00 2001
From: isra el <vernu1997@gmail.com>
Date: Sat, 8 Mar 2025 17:53:55 +0300
Subject: [PATCH 2/3] feat(web): add reply popup feature to received sms
 messages

---
 .../dashboard/(components)/received-sms.tsx   | 199 +++++++++++++++++-
 1 file changed, 198 insertions(+), 1 deletion(-)

diff --git a/web/app/(app)/dashboard/(components)/received-sms.tsx b/web/app/(app)/dashboard/(components)/received-sms.tsx
index 3d4c5e6..5bee23f 100644
--- a/web/app/(app)/dashboard/(components)/received-sms.tsx
+++ b/web/app/(app)/dashboard/(components)/received-sms.tsx
@@ -4,8 +4,201 @@ import httpBrowserClient from '@/lib/httpBrowserClient'
 import { useQuery } from '@tanstack/react-query'
 import React, { useEffect, useState } from 'react'
 import { Card, CardContent } from '@/components/ui/card'
-import { Clock } from 'lucide-react'
+import { Clock, MessageSquare, Reply } from 'lucide-react'
 import { Skeleton } from '@/components/ui/skeleton'
+import { Button } from '@/components/ui/button'
+import {
+  Dialog,
+  DialogContent,
+  DialogDescription,
+  DialogHeader,
+  DialogTitle,
+  DialogTrigger,
+} from '@/components/ui/dialog'
+import { Input } from '@/components/ui/input'
+import { Textarea } from '@/components/ui/textarea'
+import {
+  Select,
+  SelectContent,
+  SelectItem,
+  SelectTrigger,
+  SelectValue,
+} from '@/components/ui/select'
+import { useForm, Controller } from 'react-hook-form'
+import { zodResolver } from '@hookform/resolvers/zod'
+import { sendSmsSchema } from '@/lib/schemas'
+import type { SendSmsFormData } from '@/lib/schemas'
+import { useMutation } from '@tanstack/react-query'
+import { Spinner } from '@/components/ui/spinner'
+import { Check, X } from 'lucide-react'
+
+function ReplyDialog({ sms, onClose }: { sms: any; onClose?: () => void }) {
+  const [open, setOpen] = useState(false)
+
+  const {
+    mutate: sendSms,
+    isPending: isSendingSms,
+    error: sendSmsError,
+    isSuccess: isSendSmsSuccess,
+  } = useMutation({
+    mutationKey: ['send-sms'],
+    mutationFn: (data: SendSmsFormData) =>
+      httpBrowserClient.post(ApiEndpoints.gateway.sendSMS(data.deviceId), data),
+    onSuccess: () => {
+      setTimeout(() => {
+        setOpen(false)
+        if (onClose) onClose()
+      }, 1500)
+    },
+  })
+
+  const {
+    register,
+    control,
+    handleSubmit,
+    formState: { errors },
+    reset,
+  } = useForm<SendSmsFormData>({
+    resolver: zodResolver(sendSmsSchema),
+    defaultValues: {
+      deviceId: sms?.device?._id,
+      recipients: [sms.sender],
+      message: '',
+    },
+  })
+
+  const { data: devices, isLoading: isLoadingDevices } = useQuery({
+    queryKey: ['devices'],
+    queryFn: () =>
+      httpBrowserClient
+        .get(ApiEndpoints.gateway.listDevices())
+        .then((res) => res.data),
+  })
+
+  useEffect(() => {
+    if (open) {
+      reset({
+        deviceId: sms?.device?._id,
+        recipients: [sms.sender],
+        message: '',
+      })
+    }
+  }, [open, sms, reset])
+
+  return (
+    <Dialog open={open} onOpenChange={setOpen}>
+      <DialogTrigger asChild>
+        <Button variant='ghost' size='sm' className='gap-1'>
+          <Reply className='h-3.5 w-3.5' />
+          Reply
+        </Button>
+      </DialogTrigger>
+      <DialogContent className='sm:max-w-[500px]'>
+        <DialogHeader>
+          <DialogTitle className='flex items-center gap-2'>
+            <MessageSquare className='h-5 w-5' />
+            Reply to {sms.sender}
+          </DialogTitle>
+          <DialogDescription>
+            Send a reply message to this sender
+          </DialogDescription>
+        </DialogHeader>
+        <form
+          onSubmit={(e) => handleSubmit((data) => sendSms(data))(e)}
+          className='space-y-4 mt-4'
+        >
+          <div className='space-y-4'>
+            <div>
+              <Controller
+                name='deviceId'
+                control={control}
+                render={({ field }) => (
+                  <Select
+                    onValueChange={field.onChange}
+                    value={field.value}
+                    defaultValue={sms?.device?._id}
+                  >
+                    <SelectTrigger>
+                      <SelectValue placeholder='Select a device' />
+                    </SelectTrigger>
+                    <SelectContent>
+                      {devices?.data?.map((device) => (
+                        <SelectItem key={device._id} value={device._id}>
+                          {device.brand} {device.model}{' '}
+                          {device.enabled ? '' : '(disabled)'}
+                        </SelectItem>
+                      ))}
+                    </SelectContent>
+                  </Select>
+                )}
+              />
+              {errors.deviceId && (
+                <p className='text-sm text-destructive mt-1'>
+                  {errors.deviceId.message}
+                </p>
+              )}
+            </div>
+
+            <div>
+              <Input
+                type='tel'
+                placeholder='Phone Number'
+                {...register('recipients.0')}
+              />
+              {errors.recipients?.[0] && (
+                <p className='text-sm text-destructive mt-1'>
+                  {errors.recipients[0].message}
+                </p>
+              )}
+            </div>
+
+            <div>
+              <Textarea
+                placeholder='Message'
+                {...register('message')}
+                rows={4}
+              />
+              {errors.message && (
+                <p className='text-sm text-destructive mt-1'>
+                  {errors.message.message}
+                </p>
+              )}
+            </div>
+          </div>
+          {sendSmsError && (
+            <div className='flex items-center gap-2 text-destructive'>
+              <p>Error sending SMS: {sendSmsError.message}</p>
+              <X className='h-5 w-5' />
+            </div>
+          )}
+
+          {isSendSmsSuccess && (
+            <div className='flex items-center gap-2 text-green-600'>
+              <p>SMS sent successfully!</p>
+              <Check className='h-5 w-5' />
+            </div>
+          )}
+
+          <div className='flex justify-end gap-2'>
+            <Button
+              type='button'
+              variant='outline'
+              onClick={() => setOpen(false)}
+            >
+              Cancel
+            </Button>
+            <Button type='submit' disabled={isSendingSms}>
+              {isSendingSms && (
+                <Spinner size='sm' className='mr-2' color='white' />
+              )}
+              {isSendingSms ? 'Sending...' : 'Send Reply'}
+            </Button>
+          </div>
+        </form>
+      </DialogContent>
+    </Dialog>
+  )
+}
 
 export function ReceivedSmsCard({ sms }) {
   const formattedDate = new Date(sms.receivedAt).toLocaleString('en-US', {
@@ -33,6 +226,10 @@ export function ReceivedSmsCard({ sms }) {
           <div className='flex gap-2'>
             <p className='text-sm max-w-sm md:max-w-none'>{sms.message}</p>
           </div>
+
+          <div className='flex justify-end'>
+            <ReplyDialog sms={sms} />
+          </div>
         </div>
       </CardContent>
     </Card>

From 9a1fff7a5e568e38f5acbcf59b5da32edc54352b Mon Sep 17 00:00:00 2001
From: isra el <vernu1997@gmail.com>
Date: Sat, 8 Mar 2025 18:48:32 +0300
Subject: [PATCH 3/3] feat: improve retrieve sms messages query performance and
 add pagination

---
 api/src/gateway/gateway.controller.ts         |  11 +-
 api/src/gateway/gateway.dto.ts                |  37 +++++
 api/src/gateway/gateway.service.ts            |  33 +++-
 api/src/gateway/schemas/sms.schema.ts         |   3 +
 .../dashboard/(components)/received-sms.tsx   | 144 +++++++++++++++++-
 5 files changed, 218 insertions(+), 10 deletions(-)

diff --git a/api/src/gateway/gateway.controller.ts b/api/src/gateway/gateway.controller.ts
index 2d104ad..6bdf1e0 100644
--- a/api/src/gateway/gateway.controller.ts
+++ b/api/src/gateway/gateway.controller.ts
@@ -113,13 +113,20 @@ export class GatewayController {
 
   @ApiOperation({ summary: 'Get received SMS from a device' })
   @ApiResponse({ status: 200, type: RetrieveSMSResponseDTO })
+  @ApiQuery({ name: 'page', required: false, type: Number, description: 'Page number (default: 1)' })
+  @ApiQuery({ name: 'limit', required: false, type: Number, description: 'Number of items per page (default: 50, max: 100)' })
   @UseGuards(AuthGuard, CanModifyDevice)
   // deprecate getReceivedSMS route in favor of get-received-sms
   @Get(['/devices/:id/getReceivedSMS', '/devices/:id/get-received-sms'])
   async getReceivedSMS(
     @Param('id') deviceId: string,
+    @Request() req,
   ): Promise<RetrieveSMSResponseDTO> {
-    const data = await this.gatewayService.getReceivedSMS(deviceId)
-    return { data }
+    // Extract page and limit from query params, with defaults and max values
+    const page = req.query.page ? parseInt(req.query.page, 10) : 1;
+    const limit = req.query.limit ? Math.min(parseInt(req.query.limit, 10), 100) : 50;
+    
+    const result = await this.gatewayService.getReceivedSMS(deviceId, page, limit)
+    return result;
   }
 }
diff --git a/api/src/gateway/gateway.dto.ts b/api/src/gateway/gateway.dto.ts
index 6096ae7..dde4e23 100644
--- a/api/src/gateway/gateway.dto.ts
+++ b/api/src/gateway/gateway.dto.ts
@@ -195,6 +195,36 @@ export class RetrieveSMSDTO {
   updatedAt: Date
 }
 
+export class PaginationMetaDTO {
+  @ApiProperty({
+    type: Number,
+    required: true,
+    description: 'Current page number',
+  })
+  page: number;
+
+  @ApiProperty({
+    type: Number,
+    required: true,
+    description: 'Number of items per page',
+  })
+  limit: number;
+
+  @ApiProperty({
+    type: Number,
+    required: true,
+    description: 'Total number of items',
+  })
+  total: number;
+
+  @ApiProperty({
+    type: Number,
+    required: true,
+    description: 'Total number of pages',
+  })
+  totalPages: number;
+}
+
 export class RetrieveSMSResponseDTO {
   @ApiProperty({
     type: [RetrieveSMSDTO],
@@ -202,4 +232,11 @@ export class RetrieveSMSResponseDTO {
     description: 'The received SMS data',
   })
   data: RetrieveSMSDTO[]
+
+  @ApiProperty({
+    type: PaginationMetaDTO,
+    required: true,
+    description: 'Pagination metadata',
+  })
+  meta?: PaginationMetaDTO
 }
diff --git a/api/src/gateway/gateway.service.ts b/api/src/gateway/gateway.service.ts
index 87c763b..27bcb7a 100644
--- a/api/src/gateway/gateway.service.ts
+++ b/api/src/gateway/gateway.service.ts
@@ -437,7 +437,7 @@ export class GatewayService {
     return sms
   }
 
-  async getReceivedSMS(deviceId: string): Promise<RetrieveSMSDTO[]> {
+  async getReceivedSMS(deviceId: string, page = 1, limit = 50): Promise<{ data: any[], meta: any }> {
     const device = await this.deviceModel.findById(deviceId)
 
     if (!device) {
@@ -450,20 +450,47 @@ export class GatewayService {
       )
     }
 
+    // Calculate skip value for pagination
+    const skip = (page - 1) * limit;
+
+    // Get total count for pagination metadata
+    const total = await this.smsModel.countDocuments({
+      device: device._id,
+      type: SMSType.RECEIVED,
+    });
+
     // @ts-ignore
-    return await this.smsModel
+    const data = await this.smsModel
       .find(
         {
           device: device._id,
           type: SMSType.RECEIVED,
         },
         null,
-        { sort: { receivedAt: -1 }, limit: 200 },
+        { 
+          sort: { receivedAt: -1 }, 
+          limit: limit,
+          skip: skip 
+        },
       )
       .populate({
         path: 'device',
         select: '_id brand model buildId enabled',
       })
+      .lean() // Use lean() to return plain JavaScript objects instead of Mongoose documents
+
+    // Calculate pagination metadata
+    const totalPages = Math.ceil(total / limit);
+    
+    return {
+      meta: {
+        page,
+        limit,
+        total,
+        totalPages,
+      },
+      data,
+    };
   }
 
   async getStatsForUser(user: User) {
diff --git a/api/src/gateway/schemas/sms.schema.ts b/api/src/gateway/schemas/sms.schema.ts
index 2600f4e..286c082 100644
--- a/api/src/gateway/schemas/sms.schema.ts
+++ b/api/src/gateway/schemas/sms.schema.ts
@@ -62,3 +62,6 @@ export class SMS {
 }
 
 export const SMSSchema = SchemaFactory.createForClass(SMS)
+
+
+SMSSchema.index({ device: 1, type: 1, receivedAt: -1 })
diff --git a/web/app/(app)/dashboard/(components)/received-sms.tsx b/web/app/(app)/dashboard/(components)/received-sms.tsx
index 5bee23f..aeac12f 100644
--- a/web/app/(app)/dashboard/(components)/received-sms.tsx
+++ b/web/app/(app)/dashboard/(components)/received-sms.tsx
@@ -267,6 +267,7 @@ export default function ReceivedSms() {
 
   const handleTabChange = (tab: string) => {
     setCurrentTab(tab)
+    setPage(1)
   }
 
   const [currentTab, setCurrentTab] = useState('')
@@ -277,19 +278,38 @@ export default function ReceivedSms() {
     }
   }, [devices])
 
+  const [page, setPage] = useState(1)
+  const [limit, setLimit] = useState(20)
+
   const {
-    data: receivedSms,
+    data: receivedSmsResponse,
     isLoading: isLoadingReceivedSms,
     error: receivedSmsError,
   } = useQuery({
-    queryKey: ['received-sms', currentTab],
+    queryKey: ['received-sms', currentTab, page, limit],
     enabled: !!currentTab,
     queryFn: () =>
       httpBrowserClient
-        .get(ApiEndpoints.gateway.getReceivedSMS(currentTab))
+        .get(
+          `${ApiEndpoints.gateway.getReceivedSMS(
+            currentTab
+          )}?page=${page}&limit=${limit}`
+        )
         .then((res) => res.data),
   })
 
+  const receivedSms = receivedSmsResponse?.data || []
+  const pagination = receivedSmsResponse?.meta || {
+    page: 1,
+    limit: 20,
+    total: 0,
+    totalPages: 1,
+  }
+
+  const handlePageChange = (newPage: number) => {
+    setPage(newPage)
+  }
+
   if (isLoadingDevices)
     return (
       <div className='space-y-4'>
@@ -347,15 +367,129 @@ export default function ReceivedSms() {
                 Error: {receivedSmsError.message}
               </div>
             )}
-            {!isLoadingReceivedSms && !receivedSms?.data?.length && (
+            {!isLoadingReceivedSms && !receivedSms?.length && (
               <div className='flex justify-center items-center h-full'>
                 No messages found
               </div>
             )}
 
-            {receivedSms?.data?.map((sms) => (
+            {receivedSms?.map((sms) => (
               <ReceivedSmsCard key={sms._id} sms={sms} />
             ))}
+
+            {pagination.totalPages > 1 && (
+              <div className='flex justify-center mt-6 space-x-2'>
+                <Button
+                  onClick={() => handlePageChange(Math.max(1, page - 1))}
+                  disabled={page === 1}
+                  variant={page === 1 ? 'ghost' : 'default'}
+                >
+                  Previous
+                </Button>
+
+                <div className='flex flex-wrap items-center gap-2 justify-center sm:justify-start'>
+                  {/* First page */}
+                  {pagination.totalPages > 1 && (
+                    <Button
+                      onClick={() => handlePageChange(1)}
+                      variant={page === 1 ? 'default' : 'ghost'}
+                      size='icon'
+                      className={`h-8 w-8 rounded-full ${
+                        page === 1
+                          ? 'bg-primary text-primary-foreground hover:bg-primary/90'
+                          : 'hover:bg-secondary'
+                      }`}
+                    >
+                      1
+                    </Button>
+                  )}
+
+                  {/* Ellipsis if needed */}
+                  {page > 4 && pagination.totalPages > 7 && (
+                    <span className='px-1'>...</span>
+                  )}
+
+                  {/* Middle pages */}
+                  {Array.from(
+                    { length: Math.min(6, pagination.totalPages - 2) },
+                    (_, i) => {
+                      let pageToShow
+
+                      if (pagination.totalPages <= 8) {
+                        // If we have 8 or fewer pages, show pages 2 through 7 (or fewer)
+                        pageToShow = i + 2
+                      } else if (page <= 4) {
+                        // Near the start
+                        pageToShow = i + 2
+                      } else if (page >= pagination.totalPages - 3) {
+                        // Near the end
+                        pageToShow = pagination.totalPages - 7 + i
+                      } else {
+                        // Middle - center around current page
+                        pageToShow = page - 2 + i
+                      }
+
+                      // Ensure page is within bounds and not the first or last page
+                      if (
+                        pageToShow > 1 &&
+                        pageToShow < pagination.totalPages
+                      ) {
+                        return (
+                          <Button
+                            key={pageToShow}
+                            onClick={() => handlePageChange(pageToShow)}
+                            variant={page === pageToShow ? 'default' : 'ghost'}
+                            size='icon'
+                            className={`h-8 w-8 rounded-full ${
+                              page === pageToShow
+                                ? 'bg-primary text-primary-foreground hover:bg-primary/90'
+                                : 'hover:bg-secondary'
+                            }`}
+                          >
+                            {pageToShow}
+                          </Button>
+                        )
+                      }
+                      return null
+                    }
+                  )}
+
+                  {/* Ellipsis if needed */}
+                  {page < pagination.totalPages - 3 &&
+                    pagination.totalPages > 7 && (
+                      <span className='px-1'>...</span>
+                    )}
+
+                  {/* Last page */}
+                  {pagination.totalPages > 1 && (
+                    <Button
+                      onClick={() => handlePageChange(pagination.totalPages)}
+                      variant={
+                        page === pagination.totalPages ? 'default' : 'ghost'
+                      }
+                      size='icon'
+                      className={`h-8 w-8 rounded-full ${
+                        page === pagination.totalPages
+                          ? 'bg-primary text-primary-foreground hover:bg-primary/90'
+                          : 'hover:bg-secondary'
+                      }`}
+                    >
+                      {pagination.totalPages}
+                    </Button>
+                  )}
+                </div>
+
+                <Button
+                  onClick={() =>
+                    handlePageChange(Math.min(pagination.totalPages, page + 1))
+                  }
+                  disabled={page === pagination.totalPages}
+                  variant={page === pagination.totalPages ? 'ghost' : 'default'}
+                >
+                  Next
+                </Button>
+              </div>
+            )}
           </TabsContent>
         ))}
       </Tabs>